Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Data race in semi-join #17417

Merged
merged 4 commits into from
Dec 28, 2024
Merged

Fix Data race in semi-join #17417

merged 4 commits into from
Dec 28, 2024

Conversation

GuptaManan100
Copy link
Member

Description

As described in #17410 and #17411, there is a data race in the stream execute code of semi-join.

This PR adds a test to uncover the problem and fixes it.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Bug Component: Query Serving Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 labels Dec 20, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 20, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 20, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (9383943) to head (8d28914).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17417      +/-   ##
==========================================
- Coverage   67.67%   67.67%   -0.01%     
==========================================
  Files        1583     1583              
  Lines      254363   254365       +2     
==========================================
- Hits       172140   172138       -2     
- Misses      82223    82227       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 merged commit c25802d into vitessio:main Dec 28, 2024
101 checks passed
@GuptaManan100 GuptaManan100 deleted the semi-join-streaming-fixes branch December 28, 2024 09:33
This was referenced Dec 28, 2024
Open
Open
vitess-bot pushed a commit that referenced this pull request Dec 28, 2024
@vitess-bot @vitess-bot
Fix Data race in semi-join (#17417)
1e7ef9b 
Signed-off-by: Manan Gupta <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Dec 28, 2024
Merged
GuptaManan100 added a commit that referenced this pull request Dec 28, 2024
@GuptaManan100
Fix Data race in semi-join (#17417)
e0ad130 
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100 added a commit that referenced this pull request Dec 28, 2024
@GuptaManan100
Fix Data race in semi-join (#17417)
1b3223e 
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100 pushed a commit that referenced this pull request Dec 28, 2024
@vitess-bot
[release-21.0] Fix Data race in semi-join (#17417) (#17447)
12df76a 
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay systay approved these changes

@dbussink dbussink dbussink approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: Query Serving Type: Bug
Projects
None yet
Milestone
v22.0.0
4 participants
@GuptaManan100 @dbussink @systay @harshit-gangal